[webkit-reviews] review denied: [Bug 63055] Web Inspector: Feature Request: Able to remove all breakpoints : [Attachment 119836] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 63055: Web Inspector: Feature Request: Able to remove all breakpoints
https://bugs.webkit.org/show_bug.cgi?id=63055

Attachment 119836: Patch
https://bugs.webkit.org/attachment.cgi?id=119836&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119836&action=review


> Source/WebCore/inspector/front-end/BreakpointsSidebarPane.js:151
> +	   contextMenu.appendItem(WebInspector.UIString("Remove All JavaScript
Breakpoints"), this._model.removeAllBreakpoints.bind(this._model, null),
breakpointsStats.all == 0);

Can we start with introducing "Remote All Breakpoints" only? Also note that you
should have 2 strings:

WebInspector.useLowerCaseMenuTitles() ? "Remote all breakpoints" : "Remote All
Breakpoints"