[webkit-reviews] review granted: [Bug 74837] REGRESSION(r101445): [JSC] Generated code for custom getters and setters with the [Supplemental] IDL is wrong : [Attachment 119814] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Kentaro Hara <haraken at chromium.org>'s
request for review:
Bug 74837: REGRESSION(r101445): [JSC] Generated code for custom getters and
setters with the [Supplemental] IDL is wrong
https://bugs.webkit.org/show_bug.cgi?id=74837

Attachment 119814: Patch
https://bugs.webkit.org/attachment.cgi?id=119814&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=119814&action=review


>>> Source/WebCore/ChangeLog:25
>>> +		     return castedThis->str3(imp, exec);
>> 
>> Why both imp and impl? How about just using one abbreviation in both places.

> 
> Darin: Yeah, we should unify their names. Since we cannot rename
castedThis->impl() easily, we should rename 'imp' to 'impl'. But it appears
that there are already so many 'imp' in CodeGeneratorJS.pm. Is it OK to rename
it in another patch?

To me it looked like the new imp was entirely new and easy to change to impl
before it even landed. But if you’d like to do that in another patch along with
changes to lots of existing cases of imp too it’s OK with me.