[webkit-reviews] review granted: [Bug 62886] Basic display of WebVTT captions : [Attachment 119795] Updated patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Eric Carlson <eric.carlson at apple.com>'s
request for review:
Bug 62886: Basic display of WebVTT captions
https://bugs.webkit.org/show_bug.cgi?id=62886

Attachment 119795: Updated patch
https://bugs.webkit.org/attachment.cgi?id=119795&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119795&action=review


r=me, but please consider adding a test with tags in the content.  (Also, make
sure all the parts of the test are there.)

> LayoutTests/media/track/track-cue-rendering.html:65
> +	       testTrack = document.querySelectorAll('track')[0];

Nit: This could just use querySelector('track') if you so felt.