[webkit-reviews] review granted: [Bug 74303] Regression(99212): table rows get incorrect height after changing some cells' height : [Attachment 119217] Proposed fix 1: Use the same row height recalculation algorithm for |rowLogicalHeightChange| and |recalCells|.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Dec 18 18:04:21 PST 2011
Darin Adler <darin at apple.com> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 74303: Regression(99212): table rows get incorrect height after changing
some cells' height
https://bugs.webkit.org/show_bug.cgi?id=74303
Attachment 119217: Proposed fix 1: Use the same row height recalculation
algorithm for |rowLogicalHeightChange| and |recalCells|.
https://bugs.webkit.org/attachment.cgi?id=119217&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=119217&action=review
> Source/WebCore/rendering/RenderTableSection.cpp:1170
> + for (RenderObject* cell = m_grid[rowIndex].rowRenderer->firstChild();
cell; cell = cell->nextSibling()) {
What guarantees that rowRenderer is non-null?
More information about the webkit-reviews
mailing list