[webkit-reviews] review denied: [Bug 74783] [QT] WebGL can not make the frame buffer with the stencil buffer. : [Attachment 119720] patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has denied Huang Dongsung
<luxtella at company100.net>'s request for review:
Bug 74783: [QT] WebGL can not make the frame buffer with the stencil buffer.
https://bugs.webkit.org/show_bug.cgi?id=74783

Attachment 119720: patch
https://bugs.webkit.org/attachment.cgi?id=119720&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=119720&action=review


Good patch, see my usual changelog nitpicks

> Source/WebCore/ChangeLog:11
> +	   GraphicsContext3DQt was able to make the frame buffer with the depth
buffer and
> +	   the depth-stencil buffer, not with the stencil buffer.
> +	   In the case QT_OPENGL_ES_2 is defined, GraphicsContext3DQt was able
to make only
> +	   the frame buffer with the depth buffer.
> +	   This makes GraphicsContext3DQt make the frame buffer with any
combination of the
> +	   depth buffer and the stencil buffer.

Proposing alternative wording for the Changelog:

When initializing a framebuffer in OpenGL ES 2, we need to initialize the depth
and stencil buffers separately, as opposed to the combined depth-stencil buffer
we initialize for desktop GL.

> Source/WebCore/ChangeLog:14
> +

You should mention that existing WebGL tests cover this.