[webkit-reviews] review granted: [Bug 74368] Implement CSS font-size property in CSSStyleApplyProperty. : [Attachment 118902] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Luke Macpherson
<macpherson at chromium.org>'s request for review:
Bug 74368: Implement CSS font-size property in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=74368

Attachment 118902: Patch
https://bugs.webkit.org/attachment.cgi?id=118902&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118902&action=review


> Source/WebCore/css/CSSStyleApplyProperty.cpp:603
> +	   fontDescription.setKeywordSize(0);

This should be removed as it's overwritten just below.

> Source/WebCore/css/CSSStyleApplyProperty.cpp:608
> +	   if (size < 0)
> +	       return;

We should check this before copying the FontDescription to avoid unnecessary
work.

> Source/WebCore/css/CSSStyleApplyProperty.cpp:618
> +	   fontDescription.setKeywordSize(0);

This should be removed as it's overwritten just below.

> Source/WebCore/css/CSSStyleApplyProperty.cpp:623
> +	   if (size < 0)
> +	       return;

We should check this before copying the FontDescription to avoid unnecessary
work.

> Source/WebCore/css/CSSStyleApplyProperty.cpp:680
> +	       if (CSSPrimitiveValue::isUnitTypeLength(type))

if (primitiveValue->isLength())

> Source/WebCore/css/CSSStyleApplyProperty.cpp:682
> +	       else if (type == CSSPrimitiveValue::CSS_PERCENTAGE)

else if (primitiveValue->isPercentage())