[webkit-reviews] review denied: [Bug 5566] ALT attribute value sometimes not displayed when image is missing : [Attachment 98509] Fix the image rendering sizing so that broken image icon and alt text will displayed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 18 14:26:09 PST 2011


Benjamin Poulain <benjamin at webkit.org> has denied Joe Wild
<joseph.wild at nokia.com>'s request for review:
Bug 5566: ALT attribute value sometimes not displayed when image is missing
https://bugs.webkit.org/show_bug.cgi?id=5566

Attachment 98509: Fix the image rendering sizing so that broken image icon and
alt text will displayed
https://bugs.webkit.org/attachment.cgi?id=98509&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
All the magic numbers should be explained through constants and not via
comments.

And this patch needs tests for all the cases that were discussed in the
comments (explicit size via image attribute, CSS, text that fits, text that
wraps, etc).


More information about the webkit-reviews mailing list