[webkit-reviews] review granted: [Bug 74813] Interacting with GMail message lists is sluggish. : [Attachment 119771] Patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 18 11:45:47 PST 2011


mitz at webkit.org has granted Andreas Kling <kling at webkit.org>'s request for
review:
Bug 74813: Interacting with GMail message lists is sluggish.
https://bugs.webkit.org/show_bug.cgi?id=74813

Attachment 119771: Patch v2
https://bugs.webkit.org/attachment.cgi?id=119771&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=119771&action=review


> Source/WebCore/rendering/RenderTableCell.cpp:529
> +    int beforeColorProperty =
CSSProperty::resolveDirectionAwareProperty(CSSPropertyWebkitBorderBeforeColor,
table->style()->direction(), table->style()->writingMode());
> +    int afterColorProperty =
CSSProperty::resolveDirectionAwareProperty(CSSPropertyWebkitBorderAfterColor,
table->style()->direction(), table->style()->writingMode());

Do these still need to be resolved in the !computeColor case?

> Source/WebCore/rendering/RenderTableCell.h:38
> +enum EComputeBorderColor { IgnoreBorderColor, ComputeBorderColor };

Please don’t use this obsolete naming convention. A better definition would be
enum IncludeBorderColorOrNot { DoNotIncludeBorderColor, IncludeBorderColor };


More information about the webkit-reviews mailing list