[webkit-reviews] review granted: [Bug 74814] Add a scrolling thread to the scrolling coordinator : [Attachment 119768] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 74814: Add a scrolling thread to the scrolling coordinator
https://bugs.webkit.org/show_bug.cgi?id=74814

Attachment 119768: Patch
https://bugs.webkit.org/attachment.cgi?id=119768&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119768&action=review


r=me with the preprocessor guard.

> Source/WebCore/page/mac/ScrollingCoordinatorMac.mm:156
> +    static ScrollingThread& scrollingThread = *new ScrollingThread();

Y U NO DEFINE_STATIC_LOCAL?

> Source/WebKit2/WebProcess/WebPage/EventDispatcher.cpp:92
> +    MutexLocker locker(m_scrollingCoordinatorsMutex);
> +    if (ScrollingCoordinator* scrollingCoordinator =
m_scrollingCoordinators.get(pageID).get()) {
> +	   PlatformWheelEvent platformWheelEvent = platform(wheelEvent);
> +
> +	   if (scrollingCoordinator->handleWheelEvent(platformWheelEvent)) {
> +	       sendDidHandleEvent(pageID, wheelEvent);
> +	       return;
> +	   }
> +    }
> +

This block needs an ENABLE(THREADED_SCROLLING) guard.