[webkit-reviews] review granted: [Bug 74793] CSSPrimitiveValue: Inline getIdent(). : [Attachment 119738] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Dec 17 18:55:38 PST 2011


Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <kling at webkit.org>'s
request for review:
Bug 74793: CSSPrimitiveValue: Inline getIdent().
https://bugs.webkit.org/show_bug.cgi?id=74793

Attachment 119738: Patch
https://bugs.webkit.org/attachment.cgi?id=119738&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=119738&action=review


> Source/WebCore/css/CSSPrimitiveValue.h:207
> +    int getIdent() const { return m_primitiveUnitType != CSS_IDENT ? 0 :
m_value.ident; }

I would prefer equality check.


More information about the webkit-reviews mailing list