[webkit-reviews] review requested: [Bug 74768] Cache and reuse the HTMLAllCollection returned by document.all. : [Attachment 119726] Patch v2

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has asked  for review:
Bug 74768: Cache and reuse the HTMLAllCollection returned by document.all.
https://bugs.webkit.org/show_bug.cgi?id=74768

Attachment 119726: Patch v2
https://bugs.webkit.org/attachment.cgi?id=119726&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
Keep the m_baseIsRetained logic in HTMLCollection, since we can't depend on
calling Node::isDocumentNode() after ~Document().
m_baseIsRetained can go away by making all HTMLCollections cached instead,
since the collection will then never hold a ref on its base node.