[webkit-reviews] review denied: [Bug 73814] [Qt] Remove redundant m_glWidget->makeCurrent() calls in GraphicsContext3DQt. : [Attachment 119714] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Dec 17 08:01:31 PST 2011


Noam Rosenthal <noam.rosenthal at nokia.com> has denied Huang Dongsung
<luxtella at company100.net>'s request for review:
Bug 73814: [Qt] Remove redundant m_glWidget->makeCurrent() calls in
GraphicsContext3DQt.
https://bugs.webkit.org/show_bug.cgi?id=73814

Attachment 119714: Patch
https://bugs.webkit.org/attachment.cgi?id=119714&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=119714&action=review


> Source/WebCore/ChangeLog:9
> +	   Need a short description and bug URL (OOPS!)

Remove this line

> Source/WebCore/ChangeLog:14
> +	   No new tests. (OOPS!)
> +

You say "No new functionality so no new tests"


More information about the webkit-reviews mailing list