[webkit-reviews] review granted: [Bug 74771] Remove the duplicated code from ASCIICType.h : [Attachment 119703] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 74771: Remove the duplicated code from ASCIICType.h
https://bugs.webkit.org/show_bug.cgi?id=74771

Attachment 119703: Patch
https://bugs.webkit.org/attachment.cgi?id=119703&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119703&action=review


Great idea!

> Source/JavaScriptCore/ChangeLog:8
> +	   The functions were sharing similar code and were defined for the
various input type.

type -> types

> Source/JavaScriptCore/ChangeLog:9
> +	   Use template instead to avoid code duplication.

template -> templates

> Source/JavaScriptCore/wtf/ASCIICType.h:98
> + character	       count
> + ---------	       -----
> + non-spaces	       689383
> + 20	space		   294720
> + 0A	\n		   89059
> + 09	\t		   28320
> + 0D	\r		   0
> + 0C	\f		   0
> + 0B	\v		   0
> + */

Looks like you're breaking the alignment here a bit.