[webkit-reviews] review denied: [Bug 74768] Cache and reuse the HTMLAllCollection returned by document.all. : [Attachment 119699] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied Andreas Kling <kling at webkit.org>'s
request for review:
Bug 74768: Cache and reuse the HTMLAllCollection returned by document.all.
https://bugs.webkit.org/show_bug.cgi?id=74768

Attachment 119699: Patch
https://bugs.webkit.org/attachment.cgi?id=119699&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119699&action=review


> Source/WebCore/html/HTMLCollection.cpp:70
> -    if (m_baseIsRetained)
> +    if (!m_base->isDocumentNode())

Gnarf! This isn't correct, isDocumentNode() will be false after ~Document()
runs (if the HTMLCollection is being destroyed after the Document removed the
last ref.)