[webkit-reviews] review denied: [Bug 73971] [Chromium] WebFrame should have an interface to invoke spellchecking in arbitrarily : [Attachment 118994] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Shinya Kawanaka
<shinyak at chromium.org>'s request for review:
Bug 73971: [Chromium] WebFrame should have an interface to invoke spellchecking
in arbitrarily
https://bugs.webkit.org/show_bug.cgi?id=73971

Attachment 118994: Patch
https://bugs.webkit.org/attachment.cgi?id=118994&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118994&action=review


> Source/WebKit/chromium/public/WebFrame.h:421
> +    virtual void requestTextChecking(const WebNode&) = 0;

maybe this should take a WebElement instead?

from the chrome side, how do you know which WebFrame to call this
function on?  what if the focused editable content is actually in
a different frame?  are you using WebView::focusedFrame() for that?

> Source/WebKit/chromium/public/WebNode.h:113
> +    WEBKIT_EXPORT WebElement rootEditableElement() const;

it seems wrong for WebNode to know about elements.  maybe this should be a
function
on WebElement?