[webkit-reviews] review granted: [Bug 74071] [Chromium] Chromium should have EditorClientImpl::checkTextOfParagraph : [Attachment 119126] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Shinya Kawanaka
<shinyak at chromium.org>'s request for review:
Bug 74071: [Chromium] Chromium should have
EditorClientImpl::checkTextOfParagraph
https://bugs.webkit.org/show_bug.cgi?id=74071

Attachment 119126: Patch
https://bugs.webkit.org/attachment.cgi?id=119126&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119126&action=review


> Source/WebKit/chromium/public/WebTextCheckingResult.h:48
> +    // TODO(shinyak): Should be removed after we confirm Chromium does not
use it.

nit: WebKit style is to use FIXME instead of TODO(user)

> Source/WebKit/chromium/public/WebTextCheckingResult.h:94
> +    Error error; // TODO(shinyak): Should be removed after we confirm
Chromium does not use it.

TODO(user) -> FIXME

> Source/WebKit/chromium/public/WebTextCheckingResult.h:98
> +    WebVector<WebGrammarDetail> details;

it seems like there is potentially a lot of copying of data here.  have you
considered transforming WebCore::GrammarDetail and WebCore::TextCheckingResult
to be reference counted so that we can just create WebPrivatePtr<>-style
wrappers
for them at the API boundary?