[webkit-reviews] review granted: [Bug 74533] REGRESSION(r102619): Reproducible crash closing window with video + poster image inside an object element : [Attachment 119634] Patch v3 - Rename "document activation callbacks" to "page cache suspension" callbacks and use them

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 16 16:06:55 PST 2011


Darin Adler <darin at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 74533: REGRESSION(r102619): Reproducible crash closing window with video +
poster image inside an object element
https://bugs.webkit.org/show_bug.cgi?id=74533

Attachment 119634: Patch v3 - Rename "document activation callbacks" to "page
cache suspension" callbacks and use them
https://bugs.webkit.org/attachment.cgi?id=119634&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=119634&action=review


> Source/WebCore/ChangeLog:11
> +	   Elements that used to register for "document activation callbacks"
now register for "page cache suspension" callbacks.
> +	   The Document only dispatches these callbacks specifically when it
suspended in to the page cache or resumed from it.

I think this description is unnecessarily oblique. The real issue is that we
don’t need to do all this work when tearing down documents; only when
suspending documents we plan to resume later. Maybe there’s a more
straightforward way of saying that.

> Source/WebCore/dom/Document.h:982
> +    enum ReasonForInactivation {
> +	   Suspension,
> +	   Detach
> +    };

I’d rather tree this all on one line. I don’t think that “suspension” and
“detach” are parallel. Maybe call it “render tree destruction” instead of
“detach”? I wonder what the name is for a process when a document goes into a
state where it’s no longer showed in a frame, but nodes in it may still exist.


More information about the webkit-reviews mailing list