[webkit-reviews] review denied: [Bug 74743] getComputedStyle for border-bottom, border-top, border-left, border-right is not implemented. : [Attachment 119662] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Alexis Menard
<alexis.menard at openbossa.org>'s request for review:
Bug 74743: getComputedStyle for border-bottom, border-top, border-left,
border-right is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=74743

Attachment 119662: Patch
https://bugs.webkit.org/attachment.cgi?id=119662&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119662&action=review


> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:2155
> +	       const int properties[3] = { CSSPropertyBorderBottomWidth,
CSSPropertyBorderBottomStyle,
> +					   CSSPropertyBorderBottomColor};

Nit: Space before } and the 4 other cases below.

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:2156
> +	       return getCSSPropertyValuesForShorthandProperties(properties, 3,
style.get(), cssValuePool);

I wonder if wtf/dtoa/utils.h should expose ARRAY_SIZE.	Would be a separate
patch.

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:2407
> +	   if (!isPropertyImplicit(properties[i])) {

What does this check do?

>
LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-shorthand.html:31

> +e.style.borderBottom="20em solid blue";

Can we test the different properties using a loop instead of copy/pasting all
the test cases?