[webkit-reviews] review granted: [Bug 74692] invalidateNodeListsCacheAfterAttributeChanged has too many callers : [Attachment 119582] Fixed if for MICRODATA

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 74692: invalidateNodeListsCacheAfterAttributeChanged has too many callers
https://bugs.webkit.org/show_bug.cgi?id=74692

Attachment 119582: Fixed if for MICRODATA
https://bugs.webkit.org/attachment.cgi?id=119582&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119582&action=review


> Source/WebCore/dom/Node.cpp:1038
> +    if (attrName != classAttr
> +#if ENABLE(MICRODATA)
> +	   && attrName != itemscopeAttr
> +	   && attrName != itempropAttr
> +#endif
> +	   && attrName != nameAttr)
> +	   return;

If this needs to be in sync with something, can we extract this logic into a
shared function?