[webkit-reviews] review denied: [Bug 72686] [chromium] Need to prepaint tiles in TiledLayerChromium : [Attachment 119637] rebasing

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied  review:
Bug 72686: [chromium] Need to prepaint tiles in TiledLayerChromium
https://bugs.webkit.org/show_bug.cgi?id=72686

Attachment 119637: rebasing
https://bugs.webkit.org/attachment.cgi?id=119637&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119637&action=review


Ah, nope - the ChangeLog formatting is off and the script is very pick about
it.

> Source/WebCore/ChangeLog:6
> +	   No new tests. (OOPS!)

You need to remove this line and describe the tests (naming the gtest covering
this is good) - this (OOPS!) will fail an svn presubmit hook

You also need to have the "Reviewed by NOBODY (OOPS!)." line still in here. A
script will replace this with "Reviewed by James Robinson." since I set the
review+ flag.

> Source/WebCore/ChangeLog:9
> +This patch pre-paints a one tile border around the visible tiles when
> +no other visible painting occurs, and when memory is available.

this should be intended