[webkit-reviews] review granted: [Bug 74685] Give PlatformEvents a base class : [Attachment 119656] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 16 13:16:18 PST 2011


Anders Carlsson <andersca at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 74685: Give PlatformEvents a base class
https://bugs.webkit.org/show_bug.cgi?id=74685

Attachment 119656: Patch
https://bugs.webkit.org/attachment.cgi?id=119656&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=119656&action=review


> Source/WebCore/platform/PlatformEvent.h:112
> +

You should add a protected destructor here as well, that way people won't
inadvertly delete a platform event. The destructor doesn't need to be virtual.


More information about the webkit-reviews mailing list