[webkit-reviews] review requested: [Bug 71956] Cache and reuse HTMLCollections exposed by Document. : [Attachment 119657] Proposed patch v2

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has asked  for review:
Bug 71956: Cache and reuse HTMLCollections exposed by Document.
https://bugs.webkit.org/show_bug.cgi?id=71956

Attachment 119657: Proposed patch v2
https://bugs.webkit.org/attachment.cgi?id=119657&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
Okay, finally came back to this. The problem was that this patch introduced a
reference cycle between Document and its cached HTMLCollections.
This updated version avoids that by having the cached collections not retain
their base node pointers (the Document.)