[webkit-reviews] review denied: [Bug 74133] Convert some fast/regions pixel tests to reftests : [Attachment 119640] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Dec 16 11:42:54 PST 2011
Tony Chang <tony at chromium.org> has denied Jacob Goldstein <jacobg at adobe.com>'s
request for review:
Bug 74133: Convert some fast/regions pixel tests to reftests
https://bugs.webkit.org/show_bug.cgi?id=74133
Attachment 119640: Patch
https://bugs.webkit.org/attachment.cgi?id=119640&action=review
------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119640&action=review
> LayoutTests/ChangeLog:4
> + updates
> +
Did you mean to include these lines? Maybe just remove them.
> LayoutTests/fast/regions/webkit-flow-inlines-dynamic.html:39
>
> <div id="content">
Could you add some text saying what the test is testing? E.g., The text in the
test should not get out of the region.
> LayoutTests/fast/regions/webkit-flow-inlines-dynamic.html:-58
> -<script>
> -document.body.offsetWidth;
> -document.getElementById('test').appendChild(document.createTextNode(" Here
is some added content that will mess things up, since it shoves things
down."));
Is this an important part of the test? Why is it being removed?
More information about the webkit-reviews
mailing list