[webkit-reviews] review denied: [Bug 73885] DOM4 remove method : [Attachment 119631] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Erik Arvidsson <arv at chromium.org>'s
request for review:
Bug 73885: DOM4 remove method
https://bugs.webkit.org/show_bug.cgi?id=73885

Attachment 119631: Patch
https://bugs.webkit.org/attachment.cgi?id=119631&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=119631&action=review


Patch looks pretty good, but there is a problem with exception code handling.

> Source/WebCore/dom/Node.h:178
> -    void remove(ExceptionCode&);
> +    void remove(ExceptionCode& = ASSERT_NO_EXCEPTION);

This change doesn’t makes sense. If the DOM does not want an exception from
this function, then there is no reason for any caller to want an exception. We
have these exceptions only for the benefit of the DOM.

If there are any exceptions that could happen when called from the DOM, an
assert is inappropriate. Nothing that a webpage does should be able to cause an
assertion to fire.