[webkit-reviews] review denied: [Bug 74719] TextureMapper: Simplify transform manipulations. : [Attachment 119613] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has denied Jocelyn Turcotte
<jocelyn.turcotte at nokia.com>'s request for review:
Bug 74719: TextureMapper: Simplify transform manipulations.
https://bugs.webkit.org/show_bug.cgi?id=74719

Attachment 119613: Patch
https://bugs.webkit.org/attachment.cgi?id=119613&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=119613&action=review


> Source/WebCore/ChangeLog:9
> +	   - Make sure that the replica node has a complete transform and
> +	     use it directly instead of keeping a copy in the source.

I can't see how this code would work; Since the replica's parent layer is
always null, and you don't check for replicatedLayer.
Someone needs to combine the "regular" layer's transform and the replica's
local transform. 
That code was pretty tricky and is tested by many layout tests
(compositing/reflection). I see no mention in this changelog that those were
tested before+after the changes, which makes me think that these changes would
break those reflection tests :)

> Source/WebCore/ChangeLog:18
> +	   - Fix the fillsForward transform adjustment in syncAnimations and
> +	     make the intention clearer by using setTransform and setOpacity.

Different patch.