[webkit-reviews] review requested: [Bug 74722] [chromium] Add setOpaque to WebMediaPlayerClient interface, don't set VideoLayer's opaque when grabbing current frame. : [Attachment 119616] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Dec 16 09:10:53 PST 2011
Dana Jansens <danakj at chromium.org> has asked for review:
Bug 74722: [chromium] Add setOpaque to WebMediaPlayerClient interface, don't
set VideoLayer's opaque when grabbing current frame.
https://bugs.webkit.org/show_bug.cgi?id=74722
Attachment 119616: Patch
https://bugs.webkit.org/attachment.cgi?id=119616&action=review
------- Additional Comments from Dana Jansens <danakj at chromium.org>
@fischman is changing the video compositing process so that the current frame
is grabbed from the impl thread instead of the main thread. This conflicts with
our setting the LC::opaque flag when retrieving a video frame.
Instead, this adds a setOpaque() function to the WebMediaPlayerClient
interface, that forwards the flag through to the VideoLayerChromium.
The flag will be set from chromium's WebMediaPlayerImpl when it initializes its
pipeline.
More information about the webkit-reviews
mailing list