[webkit-reviews] review requested: [Bug 74706] [Qt] QtWebKit disregards LocalContentCanAccessFileUrls setting : [Attachment 119597] Proposed patch + Qt testcase.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 16 03:51:07 PST 2011


Bruno Abinader <bruno.de_oliveira at basyskom.de> has asked  for review:
Bug 74706: [Qt] QtWebKit disregards LocalContentCanAccessFileUrls setting
https://bugs.webkit.org/show_bug.cgi?id=74706

Attachment 119597: Proposed patch + Qt testcase.
https://bugs.webkit.org/attachment.cgi?id=119597&action=review

------- Additional Comments from Bruno Abinader <bruno.de_oliveira at basyskom.de>
This patch adds a check on WebCore::SubframeLoader::loadSubframe for wheter
WebCore::Settings::allowFileAccessFromFileURLs returns true or false. If true
is returned, it is assumed that a user or global setting has higher priority
than local load policy. This patch missed layout tests which I am finishing
creating, but please consider reviewing it already.


More information about the webkit-reviews mailing list