[webkit-reviews] review denied: [Bug 74686] [Forms] The "maxlength" attribute on "textarea" tag miscounts hard newlines : [Attachment 119578] Patch 1

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied yosin at chromium.org's request for
review:
Bug 74686: [Forms] The "maxlength" attribute on "textarea" tag miscounts hard
newlines
https://bugs.webkit.org/show_bug.cgi?id=74686

Attachment 119578: Patch 1
https://bugs.webkit.org/attachment.cgi?id=119578&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119578&action=review


> Source/WebCore/html/HTMLTextAreaElement.cpp:58
> +static unsigned computeLengthForSubmission(const String& str)
> +{
> +    unsigned count =  numGraphemeClusters(str);
> +    unsigned len = str.length();

We prefer complete words for variable names.  'str' 'len' are not acceptable.

> LayoutTests/ChangeLog:10
> +	   * fast/forms/textarea/textarea-maxlength-newline-expected.txt:
Added.
> +	   * fast/forms/textarea/textarea-maxlength-newline.html: Added.

The new test is not needed.
Your change for textarea-maxlength.js covers the behavior change.