[webkit-reviews] review granted: [Bug 74681] [Refactoring] Remove all global variables from prepare-ChangeLog : [Attachment 119573] rebased patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 74681: [Refactoring] Remove all global variables from prepare-ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=74681

Attachment 119573: rebased patch
https://bugs.webkit.org/attachment.cgi?id=119573&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119573&action=review


> Tools/Scripts/prepare-ChangeLog:527
> +    my $changedFilesString = "'" . join ("' '", @$changedFiles) . "'";

Nit: There is a space between join and (.

> Tools/Scripts/prepare-ChangeLog:1468
> -    my @files = @_;
> +    my ($paths, $gitCommit, $gitIndex, $mergeBase) = @_;

Why are we taking $paths instead of @files here?

> Tools/Scripts/prepare-ChangeLog:1476
> +	   my $filesString = "\"" . join ("\" \"", keys %$paths) . "\"";

Ditto about the space between join and (. By the way, can you replace all these
"\" \"" by '" "' to improve the readability?