[webkit-reviews] review denied: [Bug 74590] [Forms] Selection change by type-ahead doesn't fire 'change' event : [Attachment 119564] Patch 4

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 15 22:02:58 PST 2011


Kent Tamura <tkent at chromium.org> has denied yosin at chromium.org's request for
review:
Bug 74590: [Forms] Selection change by type-ahead doesn't fire 'change' event
https://bugs.webkit.org/show_bug.cgi?id=74590

Attachment 119564: Patch 4
https://bugs.webkit.org/attachment.cgi?id=119564&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119564&action=review


> LayoutTests/fast/forms/select/menulist-type-ahead-find.html:13
> +    const sel = document.getElementById("sel");
> +    const res = document.getElementById("res");
> +    sel.focus();

Variable "res" is not needed.
You might want to remove "sel" too.


More information about the webkit-reviews mailing list