[webkit-reviews] review granted: [Bug 73954] REGRESSION (r97745): Transitions don't work on links : [Attachment 119111] patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 73954: REGRESSION (r97745): Transitions don't work on links
https://bugs.webkit.org/show_bug.cgi?id=73954

Attachment 119111: patch
https://bugs.webkit.org/attachment.cgi?id=119111&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119111&action=review


> Source/WebCore/rendering/style/RenderStyle.h:1631
> +    const Color& visitedLinkColumnRuleColor() const { return
rareNonInheritedData->m_multiCol->m_visitedLinkColumnRuleColor; }
> +    const Color& visitedLinkTextEmphasisColor() const { return
rareInheritedData->visitedLinkTextEmphasisColor; }
> +    const Color& visitedLinkTextFillColor() const { return
rareInheritedData->visitedLinkTextFillColor; }
> +    const Color& visitedLinkTextStrokeColor() const { return
rareInheritedData->visitedLinkTextStrokeColor; }

We should cover these colors in the layout test as well.