[webkit-reviews] review denied: [Bug 64230] REGRESSION (r73385): Marquee with behavior="alternate" is not working : [Attachment 118783] updated patch

[bugzilla-daemon at webkit.org]

Andy Estes <aestes at apple.com> has denied Parag Radke <nrqv63 at motorola.com>'s
request for review:
Bug 64230: REGRESSION (r73385): Marquee with behavior="alternate" is not
working
https://bugs.webkit.org/show_bug.cgi?id=64230

Attachment 118783: updated patch
https://bugs.webkit.org/attachment.cgi?id=118783&action=review

------- Additional Comments from Andy Estes <aestes at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=118783&action=review


I applied your patch on my machine and marquee-alternate.html fails when I run
it. What guarantees that a cycle will complete in 4.6 seconds? Are you assuming
the marquee is a certain width based on the text within it? That isn't a safe
assumption.

> LayoutTests/fast/html/marquee-alternate.html:10
> +var fullCycle = 4600;

It's unfortunate that this test requires 4.6 seconds to run. You can shorten
this time by using marquee's scrollAmount and scrollDelay properties.