[webkit-reviews] review denied: [Bug 74590] [Forms] Selection change by type-ahead doesn't fire 'change' event : [Attachment 119552] Patch 2

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied yosin at chromium.org's request for
review:
Bug 74590: [Forms] Selection change by type-ahead doesn't fire 'change' event
https://bugs.webkit.org/show_bug.cgi?id=74590

Attachment 119552: Patch 2
https://bugs.webkit.org/attachment.cgi?id=119552&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119552&action=review


> LayoutTests/fast/forms/select/menulist-type-ahead-find.html:30
> +    expectEq("apple", sel.value);
> +    eventSender.keyDown(ch);
> +    expectEq(expected, sel.value);

I think these expectEq() are unnecessary.  The type-ahead feature is tested in
other test files.

> LayoutTests/fast/forms/select/menulist-type-ahead-find.html:31
> +    expectEq("PASS", res.innerText);

This is not needed.  The test result contains 'PASS' in "res" element.

> LayoutTests/fast/forms/select/menulist-type-ahead-find.html:45
> +<h1>WebKit Bug <a
href="https://bugs.webkit.org/show_bug.cgi?id=74590">74590</a></h1>

Please show the purpose of the test.  The bug number is not useful.