[webkit-reviews] review requested: [Bug 74680] [Plugins GTK/QT] Signed to Unsigned Conversion Error : [Attachment 119548] the patch file created by svn-create-patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 15 20:10:31 PST 2011


Kwangmin Bang <justine.bang at samsung.com> has asked  for review:
Bug 74680: [Plugins GTK/QT] Signed to Unsigned Conversion Error
https://bugs.webkit.org/show_bug.cgi?id=74680

Attachment 119548: the patch file created by svn-create-patch
https://bugs.webkit.org/attachment.cgi?id=119548&action=review

------- Additional Comments from Kwangmin Bang <justine.bang at samsung.com>
If signed integer variables having negative number is allocated to unsigned
short variables,
unsigned short variables will have an unexpected value.

So, if signed integer variable has negative number,fill unsigned short
variables to zero before type casting.
If not, clipRect(unsigned short) have an unexpected value cause of the first
bit for negative.


More information about the webkit-reviews mailing list