[webkit-reviews] review granted: [Bug 74383] Upstream PlatformMouseEvent and LocalizedStrings into WebCore/platform/blackberry : [Attachment 119381] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Mary Wu
<mary.wu at torchmobile.com.cn>'s request for review:
Bug 74383: Upstream PlatformMouseEvent and LocalizedStrings into
WebCore/platform/blackberry
https://bugs.webkit.org/show_bug.cgi?id=74383

Attachment 119381: Patch
https://bugs.webkit.org/attachment.cgi?id=119381&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119381&action=review


Thanks Mary for updating the patch. Notice that most of these these methods
build a WTF::String object from a C-string. We should probably leak the
WTF::String objects if these methods are called frequently instead of building
a WTF::String object on each method call.

> Source/WebCore/platform/blackberry/LocalizedStringsBlackBerry.cpp:587
> +}

Do we need to use String::fromUTF8 here? It seems like it would be sufficient
to write this as:

return String(", ...");