[webkit-reviews] review granted: [Bug 74675] Add support for accelerated compositing to the tiled Core Animation drawing area : [Attachment 119534] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 15 18:29:29 PST 2011


Andreas Kling <kling at webkit.org> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 74675: Add support for accelerated compositing to the tiled Core Animation
drawing area
https://bugs.webkit.org/show_bug.cgi?id=74675

Attachment 119534: Patch
https://bugs.webkit.org/attachment.cgi?id=119534&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119534&action=review


> Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:38
> +#import <WebCore/ScrollingCoordinator.h>

Is this one actually needed?

> Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:112
> +    // This gets called outside of the normal event loop so wrap in an
autorelease pool

Mission period at the end, OMG.


More information about the webkit-reviews mailing list