[webkit-reviews] review denied: [Bug 74547] [Chromium] Add trace events for decoding and drawing images. : [Attachment 119502] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 15 16:46:13 PST 2011


James Robinson <jamesr at chromium.org> has denied Daniel Sievers
<sievers at chromium.org>'s request for review:
Bug 74547: [Chromium] Add trace events for decoding and drawing images.
https://bugs.webkit.org/show_bug.cgi?id=74547

Attachment 119502: Patch
https://bugs.webkit.org/attachment.cgi?id=119502&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119502&action=review


> Source/WebCore/platform/graphics/skia/ImageSkia.cpp:49
> +#include "TraceEvent.h"

skia does not necessarily imply chromium, so you need the same #if PLATFORM()
guards here as elsewhere. sorry i didn't catch this the first time


More information about the webkit-reviews mailing list