[webkit-reviews] review denied: [Bug 74471] [chromium] Ensure TilingData size includes background-color tiles : [Attachment 119143] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Dec 15 16:19:40 PST 2011
James Robinson <jamesr at chromium.org> has denied Alexandre Elias
<aelias at chromium.org>'s request for review:
Bug 74471: [chromium] Ensure TilingData size includes background-color tiles
https://bugs.webkit.org/show_bug.cgi?id=74471
Attachment 119143: Patch
https://bugs.webkit.org/attachment.cgi?id=119143&action=review
------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119143&action=review
The prepareToUpdate change looks good, but the pushPropertiesTo() one looks
wrong.
> Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp:255
> + m_tiler->growLayerToContain(IntRect(IntPoint::zero(), contentBounds()));
this doesn't belong here
More information about the webkit-reviews
mailing list