[webkit-reviews] review granted: [Bug 74169] Upstream PageClientBlackBerry.h into WebCore/platform/blackberry : [Attachment 119145] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Mary Wu
<mary.wu at torchmobile.com.cn>'s request for review:
Bug 74169: Upstream PageClientBlackBerry.h into WebCore/platform/blackberry
https://bugs.webkit.org/show_bug.cgi?id=74169

Attachment 119145: Patch
https://bugs.webkit.org/attachment.cgi?id=119145&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119145&action=review


> Source/WebCore/platform/blackberry/PageClientBlackBerry.h:34
> +namespace BlackBerry {
> +namespace Platform {
> +class NetworkStreamFactory;
> +
> +namespace Graphics {
> +class Window;
> +}
> +
> +}
> +}

>From talking with Dave Levin today on IRC, this should be written as:

namespace BlackBerry {
    namespace Platform {
	class NetworkStreamFactory;
	namespace Graphics {
	    class Window;
	}
    }
}

This formatting makes the forward declarations stand out since they are
indented. Some additional remarks on this formatting are mentioned in the
description and comments of bug #36760. The comments in bug #36760 and the
discussion from Dave Levin seemed to imply that the remarks on namespace
indentation in <http://www.webkit.org/coding/coding-style.html> pertain to a
namespace that contains class/struct definitions. That is, the code style
guidelines don't pertain to a namespace that only lists forward declarations
(as is the case here).

We should look to clarify this on webkit-dev.

> Source/WebCore/platform/blackberry/PageClientBlackBerry.h:40
> +namespace WebCore {
> +class IntRect;
> +class IntSize;
> +class PluginView;
> +}

Similarly, since this namespace only lists forward declarations it should be
written as:

namespace WebCore {
    class IntRect;
    class IntSize;
    class PluginView;
}