[webkit-reviews] review granted: [Bug 74624] Warnings fixes in Interpreter.cpp and PrivateExecute.cpp : [Attachment 119459] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Dec 15 16:11:05 PST 2011
Darin Adler <darin at apple.com> has granted Andy Wingo <wingo at igalia.com>'s
request for review:
Bug 74624: Warnings fixes in Interpreter.cpp and PrivateExecute.cpp
https://bugs.webkit.org/show_bug.cgi?id=74624
Attachment 119459: Patch
https://bugs.webkit.org/attachment.cgi?id=119459&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=119459&action=review
Looks fine.
> Source/JavaScriptCore/wtf/ParallelJobsGeneric.cpp:69
> + if (s_threadPool->size() < static_cast<unsigned>(i) + 1U)
I would have changed the loop variable to be unsigned instead of putting this
cast here.
More information about the webkit-reviews
mailing list