[webkit-reviews] review granted: [Bug 74658] <!DOCTYPE html><pre>&#x0a; &#x0a; A</pre> doesn't parse correctly : [Attachment 119511] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 15 16:00:43 PST 2011 

Darin Adler <darin at apple.com> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 74658: <!DOCTYPE html><pre>&#x0a;&#x0a;A</pre> doesn't parse correctly
https://bugs.webkit.org/show_bug.cgi?id=74658

Attachment 119511: Patch
https://bugs.webkit.org/attachment.cgi?id=119511&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=119511&action=review


> Source/WebCore/html/parser/HTMLTreeBuilder.cpp:271
> +    void skipAtMostOneLeadingNewLine()

I thought the term of art was “newline” rather than “new line”. Accordingly, it
should be “Newline” rather than “NewLine”.

> Source/WebCore/html/parser/HTMLTreeBuilder.h:242
> +    bool m_skipLeadingNewLineForListing;

I think it would read a little better if it had the word “should” in it,
completing the sentence “tree builder <xxx>”.

Is the term “for listing” something from the specification? I ask, because it
seems strangely specific to one of the three tokens that trigger this.

More information about the webkit-reviews mailing list