[webkit-reviews] review granted: [Bug 74613] [qt][wk2] Viewport info panel shows wrong current scale : [Attachment 119440] Update patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 15 12:59:02 PST 2011


Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Michael Brüning
<michael.bruning at nokia.com>'s request for review:
Bug 74613: [qt][wk2] Viewport info panel shows wrong current scale
https://bugs.webkit.org/show_bug.cgi?id=74613

Attachment 119440: Update patch.
https://bugs.webkit.org/attachment.cgi?id=119440&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119440&action=review


> Source/WebKit2/UIProcess/API/qt/qwebviewportinfo.cpp:49
> +    return m_webViewPrivate->pageView->scale() /
m_webViewPrivate->interactionEngine->constraints().devicePixelRatio;

There are methods for doing this in the interaction engine class. Could you see
if it is possible to use them?


More information about the webkit-reviews mailing list