[webkit-reviews] review denied: [Bug 74625] Clang doesn't optimize away undefined OwnPtr copy constructor : [Attachment 119460] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 15 10:51:33 PST 2011


Nico Weber <thakis at chromium.org> has denied Adrienne Walker <enne at google.com>'s
request for review:
Bug 74625: Clang doesn't optimize away undefined OwnPtr copy constructor
https://bugs.webkit.org/show_bug.cgi?id=74625

Attachment 119460: Patch
https://bugs.webkit.org/attachment.cgi?id=119460&action=review

------- Additional Comments from Nico Weber <thakis at chromium.org>
This won't work, clang sets GCC.

Declaring but not defining this destructor is a bug, and from what I can tell
not necessary for recent-ish gccs. Can you try just removing that whole block?


More information about the webkit-reviews mailing list