[webkit-reviews] review granted: [Bug 72547] Text tracks should be treated differently according to their kind : [Attachment 119286] Updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 15 10:19:20 PST 2011


Sam Weinig <sam at webkit.org> has granted Eric Carlson <eric.carlson at apple.com>'s
request for review:
Bug 72547: Text tracks should be treated differently according to their kind
https://bugs.webkit.org/show_bug.cgi?id=72547

Attachment 119286: Updated patch
https://bugs.webkit.org/attachment.cgi?id=119286&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119286&action=review


> Source/WebCore/html/HTMLMediaElement.cpp:2296
> +    Settings* settings = document()->settings();
> +

You could pull the settings null check up here and avoid the duplication below.


More information about the webkit-reviews mailing list