[webkit-reviews] review granted: [Bug 74370] Hardware-backed renderLayer could avoid repainting during a positioned movement layout : [Attachment 119407] Updated change: RepaintAfterLayout -> NeedsNormalRepaint (should make the enum values less confusing) + addressed Simon's comments.

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 74370: Hardware-backed renderLayer could avoid repainting during a
positioned movement layout
https://bugs.webkit.org/show_bug.cgi?id=74370

Attachment 119407: Updated change: RepaintAfterLayout -> NeedsNormalRepaint
(should make the enum values less confusing) + addressed Simon's comments.
https://bugs.webkit.org/attachment.cgi?id=119407&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=119407&action=review


> Source/WebCore/rendering/RenderLayer.cpp:891
> +    if (m_repaintStatus == NeedsNormalRepaint)

I'm surprised you don't need casts here from unsigned to the enum.