[webkit-reviews] review granted: [Bug 72254] [GTK] Rounding errors on 32-bit machines causes tests to fail : [Attachment 119402] proposed patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 72254: [GTK] Rounding errors on 32-bit machines causes tests to fail
https://bugs.webkit.org/show_bug.cgi?id=72254

Attachment 119402: proposed patch
https://bugs.webkit.org/attachment.cgi?id=119402&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119402&action=review


Thank you!

> Tools/Scripts/webkitdirs.pm:1627
> +    # used on Chromium build.
> +    $ENV{'CXXFLAGS'} = "-march=pentium4 -msse2 -mfpmath=sse";

I think we should only pass these flags if we are on a 32-bit system.