[webkit-reviews] review denied: [Bug 74406] [Qt][WK2] Move webView.page into experimental : [Attachment 119051] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 15 07:03:36 PST 2011


Simon Hausmann <hausmann at webkit.org> has denied Rafael Brandao
<rafael.lobo at openbossa.org>'s request for review:
Bug 74406: [Qt][WK2] Move webView.page into experimental
https://bugs.webkit.org/show_bug.cgi?id=74406

Attachment 119051: Patch
https://bugs.webkit.org/attachment.cgi?id=119051&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119051&action=review


> Source/WebKit2/UIProcess/qt/QtPageClient.cpp:60
> -    m_webView->page()->update();
> +    m_webView->experimental()->page()->update();

It's ugly that we ourselves in our implementation have to use experimental API
:)

How about this:

Keep the page() accessor in QQuickWebView, but remove the Q_PROPERTY (makes it
disappear from QML). Instead
add the Q_PROPERTY to to QQuickWebViewExperimental with a forwarding accessor.


More information about the webkit-reviews mailing list