[webkit-reviews] review granted: [Bug 50999] Supports Unicode variation selector : [Attachment 119339] Patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted Kenichi Ishibashi
<bashi at chromium.org>'s request for review:
Bug 50999: Supports Unicode variation selector
https://bugs.webkit.org/show_bug.cgi?id=50999

Attachment 119339: Patch
https://bugs.webkit.org/attachment.cgi?id=119339&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119339&action=review


Looks great, r=me. EWS doesn't like your patch, but it's the same as before
modulo refactoring, so I think it's safe to land as-is.
Thanks for correcting my incorrect ToUTF8 method ;-)

> LayoutTests/ChangeLog:9
> +	   A tiny font (gw432047.ttf), which comes from glyphwiki.org and is
used by Moziila, is added for the test.

typo: Mozilla.

> LayoutTests/ChangeLog:14
> +	   * platform/chromium/test_expectations.txt: Added
fast/text/unicode-variation-selector.html. This test need rebaseline.

Just noticed that you're missing a mac result. Do you plan to land the new
results, once you got results from the mac bots?