[webkit-reviews] review granted: [Bug 68106] <table><tr><td><svg><desc><td> parses incorrectly : [Attachment 119320] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Dec 15 01:18:12 PST 2011
Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 68106: <table><tr><td><svg><desc><td> parses incorrectly
https://bugs.webkit.org/show_bug.cgi?id=68106
Attachment 119320: Patch
https://bugs.webkit.org/attachment.cgi?id=119320&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119320&action=review
LGTM. Please run the benchmark before landing. Why is Qt geborked?
> Source/WebCore/html/parser/HTMLTreeBuilder.cpp:2784
> + String characters = String(token.characters().data(),
token.characters().size());
Do we just have a copy() call? Did you test perf of this patch?
More information about the webkit-reviews
mailing list