[webkit-reviews] review granted: [Bug 74591] Refactor input type color WebCore part : [Attachment 119393] fixed nits

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 15 01:04:53 PST 2011


Kent Tamura <tkent at chromium.org> has granted Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 74591: Refactor input type color WebCore part
https://bugs.webkit.org/show_bug.cgi?id=74591

Attachment 119393: fixed nits
https://bugs.webkit.org/attachment.cgi?id=119393&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119393&action=review


> Source/WebCore/html/ColorInputType.cpp:183
>      ExceptionCode ec;
> -    colorSwatch->style()->setProperty("background-color",
element()->value(), ec);
> +    colorSwatch->style()->setProperty(CSSPropertyBackgroundColor,
element()->value(), false, ec);
>  }

nit: My comment for this part was not addressed.


More information about the webkit-reviews mailing list